Skip to content

Update pgf tutorial #28824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

ArchangeGabriel
Copy link
Contributor

PR summary

In #16281 it was missed the fact that the backend keyword was also allowing to keep interactive backends without registering the Pgf one for pdf outputs.

PR checklist

In matplotlib#16281 it was missed the fact that the `backend` keyword was also allowing to keep interactive backends without registering the Pgf one for pdf outputs.
@github-actions github-actions bot added the Documentation: user guide files in galleries/users_explain or doc/users label Sep 15, 2024
Fix typo
Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems you are trying to say "the last two methods". Bit even then that is not clearly the original intention.

@ArchangeGabriel
Copy link
Contributor Author

Yeah, I was not sure of the wording, to be honest I am not a native english speaker (and do not get to practice my english outside of my oss contributions). I am perfectly fine to change that for “The last two methods”.

I am not sure what you mean by “original intention”. I know that @anntzer added the backend keyword for quick testing purposes, but in the very precise PR he did so, #15536, he also mentioned it as being helpful for my use case of keeping the interactive backend working while saving to pdf with the pgf one, without having to go with the (less intuitive/harder to remember) backend registration.

@jklymak
Copy link
Member

jklymak commented Sep 16, 2024

If the structure is confusing and open to doubt, perhaps it could be rewritten more clearly overall.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation: user guide files in galleries/users_explain or doc/users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants