Skip to content

Add failing test for http client with retryable client when response is not initialized #58460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 7.3
Choose a base branch
from

Conversation

Seldaek
Copy link
Member

@Seldaek Seldaek commented Oct 4, 2024

Special PR for @nicolas-grekas with a failing test

Note how the first command passes, but the second fails

../../../../vendor/bin/simple-phpunit --filter testDoesNotThrowOnDestructIfExceptionCaughtEarlierWithGetStatusCode
../../../../vendor/bin/simple-phpunit --filter testDoesNotThrowOnDestructIfExceptionCaughtEarlierEvenWithoutGetStatusCode

I manually trigger __destruct in the test, but if not it then throws at the end of the phpunit execution.

calling $response->getStatusCode() to trigger response::initialize is the only difference between the two test cases.

@carsonbot carsonbot added this to the 7.2 milestone Oct 4, 2024
@fabpot fabpot modified the milestones: 7.2, 7.3 Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants