[WebProfilerBundle] do not base services on PHPUnit mocks #58413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
force-pushed
the
container-mock-register
branch
from
f783a69 to
6b0ec7c
Compare
chalasr
approved these changes
Sep 29, 2024
alexandre-daubois
approved these changes
Sep 29, 2024
xabbuh
force-pushed
the
container-mock-register
branch
from
6b0ec7c to
facd698
Compare
javiereguiluz
approved these changes
Sep 30, 2024
derrabus
reviewed
Sep 30, 2024
src/Symfony/Bundle/WebProfilerBundle/Tests/DependencyInjection/WebProfilerExtensionTest.php
Outdated
Show resolved
Hide resolved
|
The only valid usage of a mock for a service would be for setting an existing instance for a service. |
Using the service container to build services bypasses PHPUnit's mock system which means that there is no guarantuee that objects are initialized in a way expected by PHPUnit. Thus mocks may or may not work as expected.
xabbuh
force-pushed
the
container-mock-register
branch
from
facd698 to
6ed0797
Compare
derrabus
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the service container to build services bypasses PHPUnit's mock system which means that there is no guarantuee that objects are initialized in a way expected by PHPUnit. Thus mocks may or may not work as expected.