Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Notifier][JoliNotif] Allow jolicode/jolinotif 3 #58437

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

pyrech
Copy link
Contributor

@pyrech pyrech commented Oct 2, 2024

Q A
Branch? 7.2
Bug fix? no
New feature? yes
Deprecations? no
Issues none
License MIT

Allow newly version of Jolinotif to be used with the Notifier. The current bridge already used the new architecture, so nothing to change here.

@OskarStark
Copy link
Contributor

Can you please add an entry to the CHANGELOG? Thanks

composer.json Outdated Show resolved Hide resolved
@pyrech
Copy link
Contributor Author

pyrech commented Oct 2, 2024

@OskarStark As the bridge was not yet released (it was added quite recently), do I really need to add a note on the Changelog? It only contains * Add the bridge in the 7.2 section at the moment, see https://github.com/symfony/symfony/blob/7.2/src/Symfony/Component/Notifier/Bridge/JoliNotif/CHANGELOG.md

@derrabus
Copy link
Member

derrabus commented Oct 2, 2024

@OskarStark As the bridge was not yet released (it was added quite recently), do I really need to add a note on the Changelog?

No.

@OskarStark
Copy link
Contributor

You are right, no we don't need one then 👍🏻

@OskarStark OskarStark changed the title [Notifier] Allow Jolinotif v3 [Notifier][JoliNotif] Allow jolicode/jolinotif 3 Oct 3, 2024
@nicolas-grekas
Copy link
Member

Thank you @pyrech.

@nicolas-grekas nicolas-grekas merged commit 0869295 into symfony:7.2 Oct 3, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants