barry_as_FLUFL future flag does not work in new REPL
#124960
Comments
sobolevn
added
type-bug
|
Clearly this is a showstopper bug requiring @Yhg1s to delay Python 3.13.0 for another week and another RC! No respect for the FLUFL eh @pablogsal ??? 😭 |
|
I can't believe it, just last week @ambv and @pablogsal were complaining about how easter eggs were getting removed, and here they are, organising a coup! Clearly this should be fixed as soon as possible1!!!! Footnotes
|
|
Hmm, it looks like it's working in the commit that introduced the new REPL: f27f8c7 
|
|
Bisected to a3e4fec. |
|
It's failing at this line: cpython/Lib/_pyrepl/simple_interact.py Line 86 in a3e4fec |
|
Note that this is equivalent to: tree = compile(source, filename, symbol, ast.PyCF_ONLY_AST)Which doesn't use |
|
Is this acceptable? diff --git a/Lib/_pyrepl/simple_interact.py b/Lib/_pyrepl/simple_interact.py
index d65b6d0d627..6e24860d3c8 100644
--- a/Lib/_pyrepl/simple_interact.py
+++ b/Lib/_pyrepl/simple_interact.py
@@ -83,7 +83,7 @@ def showtraceback(self):
def runsource(self, source, filename="<input>", symbol="single"):
try:
- tree = ast.parse(source)
+ tree = self.compile.compiler(source, filename, symbol, ast.PyCF_ONLY_AST)
except (OverflowError, SyntaxError, ValueError):
self.showsyntaxerror(filename)
return False
diff --git a/Lib/codeop.py b/Lib/codeop.py
index 6ad60e7f850..8a77075b487 100644
--- a/Lib/codeop.py
+++ b/Lib/codeop.py
@@ -44,6 +44,7 @@
# Caveat emptor: These flags are undocumented on purpose and depending
# on their effect outside the standard library is **unsupported**.
PyCF_DONT_IMPLY_DEDENT = 0x200
+PyCF_ONLY_AST = 0x400
PyCF_ALLOW_INCOMPLETE_INPUT = 0x4000
def _maybe_compile(compiler, source, filename, symbol):
@@ -109,11 +110,13 @@ class Compile:
def __init__(self):
self.flags = PyCF_DONT_IMPLY_DEDENT | PyCF_ALLOW_INCOMPLETE_INPUT
- def __call__(self, source, filename, symbol, **kwargs):
- flags = self.flags
+ def __call__(self, source, filename, symbol, flags=0, **kwargs):
+ flags |= self.flags
if kwargs.get('incomplete_input', True) is False:
flags &= ~PyCF_DONT_IMPLY_DEDENT
flags &= ~PyCF_ALLOW_INCOMPLETE_INPUT
+ if flags & PyCF_ONLY_AST:
+ return compile(source, filename, symbol, flags, True)
codeob = compile(source, filename, symbol, flags, True)
for feature in _features:
if codeob.co_flags & feature.compiler_flag: |
|
Bug report
New REPL:
Old REPL:
I understand that this is just an easter egg :)
Linked PRs
barry_as_FLUFLfuture flag does not work in new REPL #124999The text was updated successfully, but these errors were encountered: