Skip to content

gh-124858: fix happy eyeballs refcyles #124859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 2, 2024

Conversation

graingert
Copy link
Contributor

@graingert graingert commented Oct 1, 2024

@graingert graingert marked this pull request as ready for review October 1, 2024 18:33
@gvanrossum gvanrossum removed their request for review October 1, 2024 20:58
@1st1
Copy link
Member

1st1 commented Oct 2, 2024

@graingert Thomas, do you want this to be backported?

@graingert graingert added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Oct 2, 2024
@graingert
Copy link
Contributor Author

@1st1 labels updated

@1st1 1st1 merged commit c066bf5 into python:main Oct 2, 2024
38 checks passed
@miss-islington-app
Copy link

Thanks @graingert for the PR, and @1st1 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 2, 2024
(cherry picked from commit c066bf5)

Co-authored-by: Thomas Grainger <tagrain@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 2, 2024
(cherry picked from commit c066bf5)

Co-authored-by: Thomas Grainger <tagrain@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Oct 2, 2024

GH-124912 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Oct 2, 2024
@bedevere-app
Copy link

bedevere-app bot commented Oct 2, 2024

GH-124913 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Oct 2, 2024
@graingert graingert deleted the fix-happy-eyeballs-refcycles branch October 2, 2024 23:33
willingc pushed a commit that referenced this pull request Oct 23, 2024
gh-124858: fix happy eyeballs refcyles (GH-124859)
(cherry picked from commit c066bf5)

Co-authored-by: Thomas Grainger <tagrain@gmail.com>
willingc pushed a commit that referenced this pull request Oct 23, 2024
gh-124858: fix happy eyeballs refcyles (GH-124859)
(cherry picked from commit c066bf5)

Co-authored-by: Thomas Grainger <tagrain@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants