Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport to 2.7] bpo-29529: Add .travis.yml to 2.7 branch #27

Merged
merged 4 commits into from Feb 20, 2017

Conversation

methane
Copy link
Member

@methane methane commented Feb 11, 2017

No description provided.

Copy link
Member

@zware zware left a comment

This will need some updates to handle 2.7.

.travis.yml Outdated
include:
- os: linux
language: python
python: 3.5
Copy link
Member

@zware zware Feb 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/3.5/2.7/

.travis.yml Outdated
- TESTING=docs
before_script:
- cd Doc
- make venv PYTHON=python3
Copy link
Member

@zware zware Feb 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there is no make venv on 2.7, just do pip install -U Sphinx (or add a 'venv' target, but that's a bit weird since there is no 'venv' module in 2.7).

.travis.yml Outdated
- cd Doc
- make venv PYTHON=python3
script:
- make html SPHINXBUILD="./venv/bin/python3 -m sphinx" SPHINXOPTS="-q"
Copy link
Member

@zware zware Feb 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Along with the make venv change, remove SPHINXBUILD here.

.travis.yml Outdated
- ./configure
- make -s -j4
# Need a venv that can parse covered code.
- ./python -m venv venv
Copy link
Member

@zware zware Feb 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't fly with 2.7, but I'm not sure what we can do instead to fix it. On the other hand, do we care as much about coverage on 2.7?

@brettcannon brettcannon changed the title Add .travis.yml to 2.7 branch bpo-29529: Add .travis.yml to 2.7 branch Feb 11, 2017
@brettcannon
Copy link
Member

@brettcannon brettcannon commented Feb 13, 2017

GH-74 has some proposed changes to .travis.yml.

@methane methane changed the title bpo-29529: Add .travis.yml to 2.7 branch [backport to 2.7] bpo-29529: Add .travis.yml to 2.7 branch Feb 14, 2017
Copy link
Contributor

@ncoghlan ncoghlan left a comment

All the requested changes have now been made

zware
zware approved these changes Feb 19, 2017
@zware
Copy link
Member

@zware zware commented Feb 19, 2017

There are a couple of other changes to be backported, but the changes I requested have been made.

@methane methane merged commit 98604c7 into python:2.7 Feb 20, 2017
1 check passed
@methane methane deleted the travis-27 branch Feb 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants