Skip to content

Fix for broken xml #127142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Fix for broken xml #127142

merged 1 commit into from
Nov 22, 2024

Conversation

smurav
Copy link
Contributor

@smurav smurav commented Nov 22, 2024

Fix for broken xml

Structure of PCBuild/_freeze_module.vcxproj.filters was fixed.

@smurav smurav requested a review from a team as a code owner November 22, 2024 08:44
@ghost
Copy link

ghost commented Nov 22, 2024

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link

bedevere-app bot commented Nov 22, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@smurav
Copy link
Contributor Author

smurav commented Nov 22, 2024

How can i add labels?

gh pr edit 127142 --add-label "skip issue"
GraphQL: smurav does not have the correct permissions to execute AddLabelsToLabelable (addLabelsToLabelable)

@ZeroIntensity
Copy link
Member

How can i add labels?

You can't, just ping someone with the permissions and they can adjust it for you.

FWIW, this needs a NEWS entry, as build is technically user facing.

@smurav
Copy link
Contributor Author

smurav commented Nov 22, 2024

Thanks @ZeroIntensity. Сan you add "skip news" label too?

@ZeroIntensity
Copy link
Member

Eh, alright. We do have a blurb section for build, but judging by it having one entry, I don't think we use it much. Hopefully a core dev won't yell at me for adding that :)

@zooba
Copy link
Member

zooba commented Nov 22, 2024

This doesn't actually affect build in any way - the filters file is just the structure displayed in Visual Studio (which doesn't necessarily have to be filesystem layout for C/C++).

@zooba zooba merged commit 615abb9 into python:main Nov 22, 2024
44 checks passed
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants