-
Notifications
You must be signed in to change notification settings - Fork 24k
Change persistent reduction threshold to 32 #147899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/147899
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New FailureAs of commit 93e71d1 with merge base 1e894d2 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
More context from this meta internal post: https://fb.workplace.com/groups/1075192433118967/posts/1612836222687916/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree we should use SIMDKernelFeatures to write a better heuristic here. Though this change seems fine in the shorter term.
/easycla |
1 similar comment
/easycla |
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Summary:
Increasing threshold for inductor multikernel flag from 16->32 can lead to significant performance gain. This change is safe as TORCHINDUCTOR_MULTI_KERNEL is disabled by defaul
Example benchmark:
With this change: gb/s: 987.0799446648006
Baseline: gb/s: 693.3391918370983
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @shunting314 @eellison