Refactor layout constraint selection logic #148104
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a tag is not specified on a custom operator, then inductor will assume that it needs exact strides. Test Plan: - tests + CI [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/148104
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 5b2e7c7 with merge base 58ede0c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
ciflow/inductor
module: inductor
release notes: fx
This was referenced Feb 27, 2025
zou3519
added a commit
that referenced
this pull request
Feb 27, 2025
If a tag is not specified on a custom operator, then inductor will assume that it needs exact strides. Test Plan: - tests + CI ghstack-source-id: 783f234998b49836198994f21265c9a6379c1347 Pull Request resolved: #148104
zou3519
added
the
keep-going
If a tag is not specified on a custom operator, then inductor will assume that it needs exact strides. Test Plan: - tests + CI [ghstack-poisoned]
zou3519
added a commit
that referenced
this pull request
Feb 27, 2025
If a tag is not specified on a custom operator, then inductor will assume that it needs exact strides. Test Plan: - tests + CI ghstack-source-id: 783f234998b49836198994f21265c9a6379c1347 Pull Request resolved: #148104
If a tag is not specified on a custom operator, then inductor will assume that it needs exact strides. Test Plan: - tests + CI [ghstack-poisoned]
zou3519
added a commit
that referenced
this pull request
Feb 27, 2025
If a tag is not specified on a custom operator, then inductor will assume that it needs exact strides. Test Plan: - tests + CI ghstack-source-id: fe56f431c57db7901148780fca1f3f341fc5b1ae Pull Request resolved: #148104
If a tag is not specified on a custom operator, then inductor will assume that it needs exact strides. Test Plan: - tests + CI [ghstack-poisoned]
shunting314
added a commit
that referenced
this pull request
Mar 4, 2025
Fix #148356 This is some sort of short term fix to recover the default behavior to apply layout constraint for custom ops when there are no tags. A longer term attempt to make sure Inductor always gets correct eager strides is here: #148104 cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 amjames chauhang aakhundov [ghstack-poisoned]
shunting314
added a commit
that referenced
this pull request
Mar 4, 2025
Fix #148356 This is some sort of short term fix to recover the default behavior to apply layout constraint for custom ops when there are no tags. A longer term attempt to make sure Inductor always gets correct eager strides is here: #148104 cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 amjames chauhang aakhundov [ghstack-poisoned]
shunting314
added a commit
that referenced
this pull request
Mar 4, 2025
Fix #148356 This is some sort of short term fix to recover the default behavior to apply layout constraint for custom ops when there are no tags. A longer term attempt to make sure Inductor always gets correct eager strides is here: #148104 cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 amjames chauhang aakhundov [ghstack-poisoned]
If a tag is not specified on a custom operator, then inductor will assume that it needs exact strides. Test Plan: - tests + CI [ghstack-poisoned]
zou3519
added a commit
that referenced
this pull request
Mar 5, 2025
If a tag is not specified on a custom operator, then inductor will assume that it needs exact strides. Test Plan: - tests + CI ghstack-source-id: 897e8455195de633b150ad3550e8a57b57c31b64 Pull Request resolved: #148104
pytorchmergebot
pushed a commit
that referenced
this pull request
Mar 6, 2025
Fix #148356 This is some sort of short term fix to recover the default behavior to apply layout constraint for custom ops when there are no tags. A longer term attempt to make sure Inductor always gets correct eager strides is here: #148104 Pull Request resolved: #148367 Approved by: https://github.com/eellison, https://github.com/zou3519
If a tag is not specified on a custom operator, then inductor will assume that it needs exact strides. Test Plan: - tests + CI [ghstack-poisoned]
zou3519
added a commit
that referenced
this pull request
Mar 6, 2025
If a tag is not specified on a custom operator, then inductor will assume that it needs exact strides. Test Plan: - tests + CI ghstack-source-id: ca7cb9176f4c13d3b195b5a2b32695ebba4d15fe Pull Request resolved: #148104
Closed
Significant cleanup of the code (it has gotten bad over time). This PR: - does some deduplication - cleans up the "lazy registration path" which seems to never get hit anymore... Test Plan: - tests + CI [ghstack-poisoned]
This PR: - cleans up some existing comments that don't make sense anymore - hooks up the "custom_op_default_layout_constraint" back (that seems to have broken) - cleans up the "lazy registration path" which seems to never get hit anymore Test Plan: - tests + CI [ghstack-poisoned]
This PR: - cleans up some existing comments that don't make sense anymore - hooks up the "custom_op_default_layout_constraint" back (that seems to have broken) - cleans up the "lazy registration path" which seems to never get hit anymore - adds dislike_padding to nodes that require exact strides Test Plan: - tests + CI disable padding [ghstack-poisoned]
shunting314
approved these changes
Apr 8, 2025
eellison
approved these changes
Apr 8, 2025
This PR: - cleans up some existing comments that don't make sense anymore - hooks up the "custom_op_default_layout_constraint" back (that seems to have broken) - cleans up the "lazy registration path" which seems to never get hit anymore - adds dislike_padding to nodes that require exact strides Test Plan: - tests + CI disable padding [ghstack-poisoned]
|
@pytorchbot merge -f "macos infinite queue" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
FYI: this PR adds a slight regression <1% to most benchmarks which is ok |
pytorchmergebot
pushed a commit
that referenced
this pull request
Apr 9, 2025
If a tag is not specified on a custom operator, then inductor will assume that it needs exact strides. Test Plan: - tests + CI Pull Request resolved: #150511 Approved by: https://github.com/eellison, https://github.com/shunting314 ghstack dependencies: #150495, #148104
|
@pytorchmergebot -c nosignal -m "GH job link HUD commit link" |
|
❌ 🤖 pytorchbot command failed: Try |
|
@pytorchmergebot revert -c nosignal -m "GH job link HUD commit link" |
|
@pytorchbot successfully started a revert job. Check the current status here. |
pytorchmergebot
added a commit
that referenced
this pull request
Apr 9, 2025
…0511)" This reverts commit a4bb2f1. Reverted #150511 on behalf of https://github.com/atalman due to [GH job link](https://github.com/pytorch/pytorch/actions/runs/14357056427/job/40251630946) [HUD commit link](https://hud.pytorch.org/pytorch/pytorch/commit/2e7c9d33e7f933ac3b723cb3bb05b9c88432c25c) ([comment](#148104 (comment)))
pytorchmergebot
added a commit
that referenced
this pull request
Apr 9, 2025
This reverts commit 2e7c9d3. Reverted #148104 on behalf of https://github.com/atalman due to [GH job link](https://github.com/pytorch/pytorch/actions/runs/14357056427/job/40251630946) [HUD commit link](https://hud.pytorch.org/pytorch/pytorch/commit/2e7c9d33e7f933ac3b723cb3bb05b9c88432c25c) ([comment](#148104 (comment)))
|
@zou3519 your PR has been successfully reverted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This PR:
have broken)
anymore
Test Plan:
disable padding
cc @ezyang @SherlockNoMad @EikanWang @jgong5 @wenzhe-nrv @voznesenskym @penguinwu @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov