Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-32604: Add support for a "default" arg in channel_recv(). #19770

Merged
merged 3 commits into from Apr 28, 2020
Merged

bpo-32604: Add support for a "default" arg in channel_recv(). #19770

merged 3 commits into from Apr 28, 2020

Conversation

ericsnowcurrently
Copy link
Member

@ericsnowcurrently ericsnowcurrently commented Apr 28, 2020 •
edited by miss-islington

This allows the caller to avoid creation of an exception when the channel is empty (just like dict.get() works). ChannelEmptyError is still raised if no default is provided.

https://bugs.python.org/issue32604

Automerge-Triggered-By: @ericsnowcurrently

nanjekyejoannah
nanjekyejoannah approved these changes Apr 28, 2020
View changes
Copy link
Member

@nanjekyejoannah nanjekyejoannah left a comment

Makes sense to me.

Modules/_xxsubinterpretersmodule.c Outdated Show resolved Hide resolved
@ericsnowcurrently ericsnowcurrently added the 🤖 automerge PR will be merged once it's been approved and all CI passed label Apr 28, 2020
@miss-islington
Copy link
Contributor

miss-islington commented Apr 28, 2020

@ericsnowcurrently: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 5e8c691 into python:master Apr 28, 2020
4 checks passed
@ericsnowcurrently ericsnowcurrently deleted the channel-recv-default branch Apr 28, 2020
@ericsnowcurrently ericsnowcurrently mentioned this pull request Apr 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nanjekyejoannah nanjekyejoannah

Assignees
No one assigned
Labels
🤖 automerge PR will be merged once it's been approved and all CI passed skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ericsnowcurrently @miss-islington @nanjekyejoannah @the-knights-who-say-ni @bedevere-bot