Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.7] bpo-35351: Pass link time optimization flags to CFLAGS_NODIST (GH-10797) #10893

Merged
merged 1 commit into from
Dec 4, 2018

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Dec 4, 2018

When using link time optimizations, the -flto flag is passed to
BASECFLAGS, which makes it propagate to distutils. Those flags
should be reserved for the interpreter and the stdlib extension
modules only, thus moving those flags to CFLAGS_NODIST.
(cherry picked from commit f92c7aa)

Co-authored-by: stratakis cstratak@redhat.com

https://bugs.python.org/issue35351

…GH-10797)

When using link time optimizations, the -flto flag is passed to
BASECFLAGS, which makes it propagate to distutils. Those flags
should be reserved for the interpreter and the stdlib extension
modules only, thus moving those flags to CFLAGS_NODIST.
(cherry picked from commit f92c7aa)

Co-authored-by: stratakis <cstratak@redhat.com>
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington
Copy link
Contributor Author

@stratakis and @vstinner: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 1751423 into python:3.7 Dec 4, 2018
@miss-islington miss-islington deleted the backport-f92c7aa-3.7 branch December 4, 2018 15:06
@miss-islington
Copy link
Contributor Author

@stratakis and @vstinner: Status check is done, and it's a success ✅ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants