Use `assert*` comparison methods in `test_timer_comparison` #129513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

kumaraditya303 merged 2 commits into python:main from alex-semenyuk:fix-test_timer_comparison

Mar 28, 2025

Contributor

alex-semenyuk commented Jan 31, 2025

Use assertLess, assertGreaterEqual etc. for test_timer_comparison to remove TODO

alex-semenyuk requested review from 1st1, asvetlov, kumaraditya303 and willingc as code owners

January 31, 2025 12:12

ghost commented Jan 31, 2025 •

edited by ghost

Loading

All commit authors signed the Contributor License Agreement.

bedevere-app bot added awaiting review tests labels

bedevere-app bot commented Jan 31, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

skirpichev added skip issue skip news labels

Contributor Author

alex-semenyuk commented Mar 1, 2025

friendly ping @1st1 @asvetlov @kumaraditya303 @willingc

kumaraditya303 reviewed

View reviewed changes

Lib/test/test_asyncio/test_events.py Show resolved Hide resolved

kumaraditya303 reviewed

View reviewed changes

Lib/test/test_asyncio/test_events.py Show resolved Hide resolved

kumaraditya303 requested changes

View reviewed changes

Lib/test/test_asyncio/test_events.py Outdated Show resolved Hide resolved

bedevere-app bot added awaiting changes and removed awaiting review labels

bedevere-app bot commented Mar 2, 2025

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

picnixz changed the title ~~Fix TODO for test_timer_comparison~~ Use assert* comparison methods in test_timer_comparison

kumaraditya303 reviewed

View reviewed changes

Lib/test/test_asyncio/test_events.py Show resolved Hide resolved

alex-semenyuk force-pushed the fix-test_timer_comparison branch 3 times, most recently from b8becb9 to fa9b647 Compare

March 20, 2025 22:23

alex-semenyuk requested a review from kumaraditya303

March 21, 2025 05:05

Contributor Author

alex-semenyuk commented Mar 21, 2025

I have made the requested changes; please review again

bedevere-app bot added awaiting change review and removed awaiting changes labels

bedevere-app bot commented Mar 21, 2025

Thanks for making the requested changes!

@kumaraditya303: please review the changes made to this pull request.

Contributor Author

alex-semenyuk commented Mar 27, 2025

friendly ping @kumaraditya303

kumaraditya303 reviewed

View reviewed changes

Lib/test/test_asyncio/test_events.py Show resolved Hide resolved

kumaraditya303 reviewed

View reviewed changes

Lib/test/test_asyncio/test_events.py Show resolved Hide resolved

kumaraditya303 reviewed

View reviewed changes

Lib/test/test_asyncio/test_events.py Show resolved Hide resolved


          Use assert* comparison methods in test_timer_comparison

eb10ab7

alex-semenyuk force-pushed the fix-test_timer_comparison branch from fa9b647 to eb10ab7 Compare

March 27, 2025 18:28

kumaraditya303 approved these changes

View reviewed changes

bedevere-app bot added awaiting merge and removed awaiting change review labels

alex-semenyuk requested a review from picnixz

March 28, 2025 10:05


          Merge branch 'main' into fix-test_timer_comparison

09c2cb0

kumaraditya303 enabled auto-merge (squash)

March 28, 2025 13:59

kumaraditya303 merged commit 27d1443 into python:main

38 checks passed

bedevere-app bot removed the awaiting merge label

seehwan pushed a commit to seehwan/cpython that referenced this pull request


          Use assert* comparison methods in test_timer_comparison (python#1…

51c9953

…29513)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

kumaraditya303 kumaraditya303 approved these changes

1st1 Awaiting requested review from 1st1 1st1 is a code owner

asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

willingc Awaiting requested review from willingc willingc is a code owner

picnixz Awaiting requested review from picnixz

Labels

skip issue skip news tests