gh-127081: add critical sections to dbm objects
#132749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dbm_* functions are not thread-safe, naturally. Add critical sections to protect their use.
duaneg
requested review from
corona10,
erlend-aasland and
serhiy-storchaka
as code owners
picnixz
changed the title
dbm objects
There was a problem hiding this comment.
In general, it's easier to add lock_held variations of functions instead of adding inline critical sections with goto. For example:
static int
dbm_something_lock_held(PyObject *self)
{
/* ... */
}
static int
dbm_something(PyObject *self)
{
int result;
Py_BEGIN_CRITICAL_SECTION(self);
result = dbm_something_lock_held(self);
Py_END_CRITICAL_SECTION();
return result;
}Would you mind switching over to that pattern here?
For sure, that would be much more robust, thanks! |
…ction instead of using gotos everywhere.
kumaraditya303
approved these changes
May 8, 2025
|
Sorry for the delay, I will review during the PyCon sprint. |
Would you like to update clinic again? |
|
Oh it's not relatede to dbms. |
corona10
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dbm_* functions are not thread-safe, naturally. Add critical sections to protect their use.