[3.13] gh-132578: Rename the threading.Thread._handle field (GH-132696)
#132789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…H-132696) Commit `0e9c364f` introduced the `_handle` field on instances of `threading.Thread`. Unfortunately it's fairly common for subclasses of `threading.Thread` to define a `_handle()` method, which is shadowed by the new field. (cherry picked from commit 3cfab44) Co-authored-by: mpage <mpage@meta.com>
This was referenced Apr 21, 2025
|
Let's hold off on merging this until we've got a clearer picture of the extent of the breakage and the risk of this change. (See #132696 (comment)) |
You broke every package that was relying on _handle not being a shadowing, so we are past the stage of worrying about breaking previously unbroken libraries. There currently is a way smaller amount of packages that rely on _handle. I would argue for renaming as soon as possible, since newly created packages are more likely to still be maintained compared to older packages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit
0e9c364fintroduced the_handlefield on instances ofthreading.Thread. Unfortunately it's fairly common for subclassesof
threading.Threadto define a_handle()method, which is shadowedby the new field.
(cherry picked from commit 3cfab44)
Co-authored-by: mpage mpage@meta.com