Skip to content

/ cpython Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-40893: Add TkDND support to tkinter #20896

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

bpo-40893: Add TkDND support to tkinter #20896

wants to merge 20 commits into from
+1,020 −16

Conversation

@E-Paine
Copy link
Contributor

@E-Paine E-Paine commented Jun 15, 2020 •
edited by bedevere-bot

https://bugs.python.org/issue40893
E-Paine added 2 commits Jun 13, 2020
@E-Paine
Added TkDND support to tkinter
9a27b14
@E-Paine
Added news item
46995aa
E-Paine
E-Paine reviewed Jun 15, 2020
View changes
Doc/library/tkinter.rst Outdated Show resolved Hide resolved
E-Paine and others added 12 commits Jun 16, 2020
@E-Paine
Changed doc to fix build bots
986796a
@E-Paine
Updated to use return properly
8f357fe 
The `return` command is now used to get the binding returns to TkDND rather than the `set` command (for details on `-level 0` see https://www.tcl.tk/man/tcl8.6/TclCmd/return.htm#M18)
@E-Paine
Added support for more types
8fbd233
@E-Paine
Fixed whitespace
a9d5751
@E-Paine
Removed final newline in tkinter.rst
ff753b4
@E-Paine
Fixed TEXT_PLAIN_UNICODE value
4caf8bc
Added the "DEFAULT" constant
fc7818f
@E-Paine
Fixed "TEXT_HTML_UNICODE" value
4eaf1f3
@E-Paine
Added new TkDND tests
5022ce8 
Added a few tests for the new bindings
@E-Paine
Remove unused import
fb3337e 
Removed an import introduced early in development (which I forgot to remove)
Drafted whatsnew and changed ACKS
3aa441a
@E-Paine
Fixed whatnew typo
074b395
@E-Paine
Copy link
Contributor Author

@E-Paine E-Paine commented Jun 26, 2020

I don't think I have forgotten anything, so am marking this ready for review (apologies about the messy commit history)

@E-Paine E-Paine marked this pull request as ready for review Jun 26, 2020
@E-Paine E-Paine requested a review from as a code owner Jun 26, 2020
E-Paine added 5 commits Jun 26, 2020
@E-Paine
Updated platform_independent_types warnings
637230f
@E-Paine
Merge branch 'master' into tkdnd
fcb4957
@E-Paine
Added "TkdndVersion" variable
33a6203
@E-Paine
Merge branch 'master' into tkdnd
2df1ab0
@E-Paine
Added data_raw and data_split event attributes
d71cef1
@E-Paine E-Paine mentioned this pull request Jul 8, 2020
Closed
@E-Paine
Merge branch 'master' into tkdnd
f5c551c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@python/windows-team windows-team

Assignees
No one assigned
Labels
awaiting review CLA signed
Projects
None yet
Milestone
No milestone
3 participants
@E-Paine @the-knights-who-say-ni @bedevere-bot