Skip to content

/ Chart.js

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused getRingIndex from Doughnut #8521

Merged
merged 1 commit into from Feb 24, 2021
Merged

Remove unused getRingIndex from Doughnut #8521

merged 1 commit into from Feb 24, 2021
+1 −14

Conversation

@kurkle
Copy link
Collaborator

@kurkle kurkle commented Feb 24, 2021

No description provided.

@kurkle
Remove unused getRingIndex from Doughnut
Verified
This commit was signed with a verified signature.
kurkle Jukka Kurkela
GPG key ID: 3EEC947987C7AD85 Learn about signing commits
Loading status checks…
d418be9
@kurkle kurkle added breaking change type: chore labels Feb 24, 2021
@etimberg
etimberg approved these changes Feb 24, 2021
View changes
@etimberg etimberg added this to the Version 3.0 milestone Feb 24, 2021
@kurkle
Copy link
Collaborator Author

@kurkle kurkle commented Feb 24, 2021

Filename Size Change
dist/chart.esm.js 65.7 kB -46 B (0%)
dist/chart.js 83.3 kB -46 B (0%)
dist/chart.min.js 59.2 kB -22 B (0%)
@etimberg etimberg merged commit 12e9020 into chartjs:master Feb 24, 2021
10 checks passed
10 checks passed
build (ubuntu-latest)
Details
build
Details
build (windows-latest)
Details
finish
Details
Coveralls - ubuntu-latest-chrome Coverage remained the same at 94.974%
Details
Coveralls - ubuntu-latest-firefox Coverage remained the same at 94.871%
Details
Coveralls - windows-latest-chrome Coverage increased (+0.07%) to 94.989%
Details
Coveralls - windows-latest-firefox Coverage increased (+0.07%) to 94.871%
Details
codeclimate All good!
Details
coverage/coveralls Coverage increased (+0.07%) to 94.989%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etimberg etimberg

Assignees
No one assigned
Labels
breaking change type: chore
Projects
None yet
Milestone
Version 3.0
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@kurkle @etimberg