Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.11] Clarify re docs for byte pattern group names (GH-99308) #101001

Open
wants to merge 1 commit into
base: 3.11
Choose a base branch
from
Open

[3.11] Clarify re docs for byte pattern group names (GH-99308) #101001

wants to merge 1 commit into from
+6 −2

Conversation

Kentzo
Copy link
Contributor

@Kentzo Kentzo commented Jan 12, 2023 •
edited by bedevere-bot

@bedevere-bot bedevere-bot mentioned this pull request Jan 12, 2023
Open
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news labels Jan 12, 2023
@slateny
Copy link
Contributor

slateny commented Jan 14, 2023

Per comment I don't believe there should be a backport for this.

@Kentzo
Copy link
Contributor Author

Kentzo commented Jan 14, 2023

#99308 (comment) says otherwise

CAM-Gerlach
CAM-Gerlach reviewed Jan 14, 2023
View changes
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Kentzo . One set of suggestions, otherwise LGTM

Doc/library/re.rst
@@ -418,7 +418,8 @@ The special characters are:
+---------------------------------------+----------------------------------+

.. deprecated:: 3.11
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.. deprecated:: 3.11
.. deprecated-removed:: 3.11 3.12

Use the most appropriate and specific directive here

Doc/library/re.rst
@@ -494,6 +495,8 @@ The special characters are:

.. deprecated:: 3.11
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.. deprecated:: 3.11
.. deprecated-removed:: 3.11 3.12

Doc/library/re.rst
@@ -1015,7 +1018,8 @@ Functions

.. deprecated:: 3.11
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.. deprecated:: 3.11
.. deprecated-removed:: 3.11 3.12

@CAM-Gerlach CAM-Gerlach requested a review from hauntsaninja Jan 14, 2023
hauntsaninja
hauntsaninja approved these changes Jan 17, 2023
View changes
Copy link
Contributor

@hauntsaninja hauntsaninja left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for backporting this!

Looks like it's common enough for past versions of docs to contain "removed" for future versions of Python, so would you mind applying CAM's suggestions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CAM-Gerlach CAM-Gerlach

@hauntsaninja hauntsaninja

Assignees
No one assigned
Labels
awaiting merge docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Kentzo @slateny @hauntsaninja @CAM-Gerlach @bedevere-bot