Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

staticcheck: re-enable for go1.18 #2746

Merged
merged 2 commits into from Apr 5, 2022
Merged

Conversation

milas
Copy link
Contributor

@milas milas commented Apr 5, 2022

As of honnef.co/go/tools@v0.3.0, staticcheck supports Go 1.18 and generics.
The dependency was bumped here by dependabot in #2738, but the no-op fallback configs needed to be removed.

See also #2649 for overall Go 1.18/generics support progress.

As of honnef.co/go/tools@v0.3.0, `staticcheck` supports Go 1.18
and generics. The dependency was bumped here by dependabot in
golangci#2738, but the no-op fallback configs needed
to be removed.

See also golangci#2649 for overall Go 1.18/generics
support progress.
@boring-cyborg
Copy link

@boring-cyborg boring-cyborg bot commented Apr 5, 2022

Hey, thank you for opening your first Pull Request !

@CLAassistant
Copy link

@CLAassistant CLAassistant commented Apr 5, 2022

CLA assistant check
All committers have signed the CLA.

@ldez ldez changed the title staticcheck: re-enable for Go 1.18 staticcheck: re-enable for go1.18 Apr 5, 2022
@ldez ldez added the linter: update version label Apr 5, 2022
@ldez ldez self-requested a review Apr 5, 2022
ldez
ldez approved these changes Apr 5, 2022
Copy link
Member

@ldez ldez left a comment

I forgot to add that in PR #2738 🤦‍♂️ , I have done the changes locally but I missed my commit...

Thank you.

@ldez ldez merged commit f5b92e1 into golangci:master Apr 5, 2022
16 checks passed
@milas milas deleted the enable-staticcheck-1.18 branch Apr 5, 2022
@milas
Copy link
Contributor Author

@milas milas commented Apr 5, 2022

No problem, happy to help! 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linter: update version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants