dev: remove some TODO #2743
Merged
dev: remove some TODO #2743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ldez
commented
Apr 3, 2022
•
- use go1.18 to test the previous version of golangci-lint
- update gomnd configuration
bombsimon
approved these changes
Apr 3, 2022
| - '0' | ||
| - '1' | ||
| - '2' | ||
| - '3' |
There was a problem hiding this comment.
Must say a bit confusing that a list of numbers are treated as strings. (Don't mean this PR, saw this is how it's handled upstream but didn't know).
There was a problem hiding this comment.
Yes I know, I documented that https://golangci-lint.run/usage/linters/#gomnd.
There was a problem hiding this comment.
FYI it's for the compatibility with the old configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.