Hey, thank you for opening your first Pull Request !

All committers have signed the CLA.

Hello @xobotyi,

why didn't you do a PR on exhaustivestruct instead of creating a copy?

I think that you will have a license issue.

@ldez pr is there for like.. half a year now. mbilski/exhaustivestruct#17

Linter name and codebases are different (codebase, actually, is complete rewrite) why there should be a licensing issues?

Not even saying that exhaustivestruct is published under MIT licence, that does not forbid that.

Not even saying that exhaustivestruct is published under MIT licence, that does not forbid that.

The MIT license is clear:

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

@ldez as said - the code is completely mine and have nothing in common (except purpose and usage of analyzer) with other linter - it can't be treated as "modification".

My login is LDEZ

@ldez oh that's why siggestion didn't worked out😂
Visually, on mobile app it looks identical😅

also, you don't need to ping me on every message.

Can you rebase your PR? Thanks.

Done

You don't need to squash, the PR is squashed during the merge.
It's better to keep the history of the PR changes.

I dont squash, it is ammend (habit from gerrit - review tool that im using at work).

I dont squash, it is ammend (habit from gerrit - review tool that im using at work).

The conclusion is the same: all the previous commits have been squashed into one commit.

this is not a good practice on GitHub because we lost the history of changes.

Otherwise, I recommend using git push --force-with-lease instead of git push -f or git push --force.

https://git-scm.com/docs/git-push

I also recommend not using the branch master but a dedicated branch when creating PR.

https://blog.jasonmeridth.com/posts/do-not-issue-pull-requests-from-your-master-branch/