Skip to content

/ Chart.js

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename scaleLabel to title in scale options #8576

Merged
merged 1 commit into from Mar 6, 2021
Merged

Rename scaleLabel to title in scale options #8576

merged 1 commit into from Mar 6, 2021
+149 −147

Conversation

@etimberg
Copy link
Member

@etimberg etimberg commented Mar 6, 2021

Renames scaleOpts.scaleLabel to scaleOpts.title and scaleOpts.scaleLabel.labelString to scaleOpts.title.text. The scale title is now consistent with the legend and chart title options.
@etimberg
Rename scaleLabel to title in scale options
Loading status checks…
1e00f33
@etimberg etimberg added the breaking change label Mar 6, 2021
@kurkle
kurkle approved these changes Mar 6, 2021
View changes
@kurkle
Copy link
Collaborator

@kurkle kurkle commented Mar 6, 2021

Filename Size Change
dist/chart.esm.js 66 kB -17 B (0%)
dist/chart.js 83.6 kB -13 B (0%)
dist/chart.min.js 59.6 kB -6 B (0%)
@etimberg etimberg merged commit a23f1de into chartjs:master Mar 6, 2021
10 checks passed
10 checks passed
build (ubuntu-latest)
Details
build
Details
build (windows-latest)
Details
finish
Details
Coveralls - ubuntu-latest-chrome First build on scale-label-rename at 95.24%
Details
Coveralls - ubuntu-latest-firefox First build on scale-label-rename at 95.121%
Details
Coveralls - windows-latest-chrome Coverage remained the same at 95.225%
Details
Coveralls - windows-latest-firefox Coverage decreased (-0.0%) to 95.121%
Details
codeclimate All good!
Details
coverage/coveralls Coverage remained the same at 95.24%
Details
@etimberg etimberg deleted the etimberg:scale-label-rename branch Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurkle kurkle

Assignees
No one assigned
Labels
breaking change
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@etimberg @kurkle