Skip to content

Have unit tests extends RxJavaTest - 3 #6595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2019
Merged

Have unit tests extends RxJavaTest - 3 #6595

merged 1 commit into from
Jul 29, 2019

Conversation

RomanWuattier
Copy link
Contributor

This commit updates the unit tests of the following operators:

  • single
  • subjects
  • subscribers
    And for internal operators:
  • internal.disposable
  • internal.fuctions
  • internal.observers
  • internal.queue
  • interanl.schedulers
  • internal.subscribers
  • internal.subscriptions
  • internal.operator.completable

Related: #6583

@RomanWuattier
Have unit tests extends RxJavaTest - 3
f6a54e7 
This commit updates the unit tests of the following operators:
* single
* subjects
* subscribers
And for internal operators:
* internal.disposable
* internal.fuctions
* internal.observers
* internal.queue
* interanl.schedulers
* internal.subscribers
* internal.subscriptions
* internal.operator.completable

Related: ReactiveX#6583
@codecov
Copy link

codecov bot commented Jul 28, 2019

Codecov Report

Merging #6595 into 3.x will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #6595      +/-   ##
============================================
- Coverage     98.22%   98.13%   -0.09%     
+ Complexity     6185     6182       -3     
============================================
  Files           678      678              
  Lines         44908    44908              
  Branches       6214     6214              
============================================
- Hits          44111    44071      -40     
- Misses          266      286      +20     
- Partials        531      551      +20
Impacted Files Coverage Δ Complexity Δ
...ernal/operators/flowable/FlowableFlatMapMaybe.java 88.88% <0%> (-6.77%) 2% <0%> (ø)
...l/operators/observable/ObservableFlatMapMaybe.java 89.54% <0%> (-3.93%) 2% <0%> (ø)
...nternal/operators/parallel/ParallelSortedJoin.java 92.7% <0%> (-2.92%) 2% <0%> (ø)
...a/io/reactivex/internal/util/QueueDrainHelper.java 97.22% <0%> (-2.78%) 56% <0%> (-2%)
...activex/internal/observers/QueueDrainObserver.java 97.43% <0%> (-2.57%) 21% <0%> (-1%)
...nternal/operators/observable/ObservableWindow.java 98% <0%> (-2%) 3% <0%> (ø)
.../io/reactivex/disposables/CompositeDisposable.java 98.14% <0%> (-1.86%) 39% <0%> (-1%)
...ternal/operators/observable/ObservablePublish.java 98.19% <0%> (-1.81%) 17% <0%> (-1%)
...ava/io/reactivex/processors/BehaviorProcessor.java 96.58% <0%> (-1.47%) 51% <0%> (+1%)
...ternal/operators/completable/CompletableMerge.java 97.61% <0%> (-1.2%) 2% <0%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 177d468...f6a54e7. Read the comment docs.

@akarnokd akarnokd added this to the 3.0 milestone Jul 29, 2019
@akarnokd akarnokd merged commit 5c3d4c6 into ReactiveX:3.x Jul 29, 2019
@akarnokd akarnokd mentioned this pull request Aug 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akarnokd akarnokd akarnokd approved these changes

@vanniktech vanniktech vanniktech approved these changes

Assignees
No one assigned
Labels
3.x Test
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@RomanWuattier @akarnokd @vanniktech