Skip to content

/ Chart.js

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add outerRadius option to doughnut/pie #8487

Merged
merged 1 commit into from Feb 21, 2021
Merged

Add outerRadius option to doughnut/pie #8487

merged 1 commit into from Feb 21, 2021
+101 −12

Conversation

@kurkle
Copy link
Collaborator

@kurkle kurkle commented Feb 21, 2021

Closes: #3923
@kurkle
Add outerRadius option to doughnut/pie
Verified
This commit was signed with a verified signature.
kurkle Jukka Kurkela
GPG key ID: 3EEC947987C7AD85 Learn about signing commits
Loading status checks…
52ea450
@kurkle
Copy link
Collaborator Author

@kurkle kurkle commented Feb 21, 2021

Conversation in #6882 should be considered here. Maybe radius would be better name for the option. I did not change the cutout yet, but I can do that in this same PR if we agree on it.
@etimberg
etimberg approved these changes Feb 21, 2021
View changes
@etimberg etimberg added this to the Version 3.0 milestone Feb 21, 2021
@etimberg etimberg merged commit 65bfacd into chartjs:master Feb 21, 2021
10 checks passed
10 checks passed
build (ubuntu-latest)
Details
build
Details
build (windows-latest)
Details
finish
Details
Coveralls - ubuntu-latest-chrome Coverage decreased (-0.01%) to 94.655%
Details
Coveralls - ubuntu-latest-firefox Coverage increased (+0.002%) to 94.552%
Details
Coveralls - windows-latest-chrome Coverage increased (+0.002%) to 94.669%
Details
Coveralls - windows-latest-firefox Coverage increased (+0.002%) to 94.552%
Details
codeclimate All good!
Details
coverage/coveralls Coverage increased (+0.002%) to 94.669%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etimberg etimberg

Assignees
No one assigned
Labels
type: enhancement
Projects
None yet
Milestone
Version 3.0
Linked issues

Successfully merging this pull request may close these issues.

Pie/Dougnut radius
2 participants
@kurkle @etimberg