Skip to content

/ Chart.js

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decimation plugin fixes #8467

Merged
merged 4 commits into from Feb 20, 2021
Merged

Decimation plugin fixes #8467

merged 4 commits into from Feb 20, 2021
+37 −7

Conversation

@etimberg
Copy link
Member

@etimberg etimberg commented Feb 20, 2021 •
edited

  • Decimation plugin no longer duplicates data points
  • Decimation plugin no longer changes the data order

No Decimation

No decimation

With Decimation

decimation
@etimberg
fix: Decimation plugin no longer changes the data order
Loading status checks…
6e4d05a 
fix: Decimation plugin no longer duplicates data points
@etimberg etimberg added the type: bug label Feb 20, 2021
etimberg added 3 commits Feb 20, 2021
@etimberg
Use nullOrUndef helper instead of direct check
e7eb613
@etimberg
Compute averageX value when decimating data using minMax decimation
Loading status checks…
f3cc712
@etimberg
Place last point of interval at real X
Loading status checks…
46e1d72 
This reduces the fuzziness on screens with devicePixelRatio > 1
@etimberg
Copy link
Member Author

@etimberg etimberg commented Feb 20, 2021

Size Change: +292 B (0%)

Total Size: 226 kB

Filename Size Change
dist/chart.esm.js 65.4 kB +108 B (0%)
dist/chart.js 82.7 kB +114 B (0%)
dist/chart.min.js 58.9 kB +70 B (0%)
@kurkle
kurkle approved these changes Feb 20, 2021
View changes
@etimberg etimberg merged commit 709dc3e into chartjs:master Feb 20, 2021
8 checks passed
8 checks passed
build (ubuntu-latest)
Details
build
Details
build (windows-latest)
Details
finish
Details
Coveralls - ubuntu-latest-chrome Coverage decreased (-0.1%) to 95.083%
Details
Coveralls - ubuntu-latest-firefox Coverage decreased (-0.2%) to 94.979%
Details
codeclimate 1 fixed issue
Details
coverage/coveralls Coverage decreased (-0.1%) to 95.098%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurkle kurkle

Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@etimberg @kurkle