C# Cleanup and refactoring #5131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
reviewed
Feb 12, 2021
csharp/extractor/Semmle.Extraction.CSharp/Entities/Method.AstLineCounter.cs
Outdated
Show resolved
Hide resolved
hvitved
reviewed
Feb 15, 2021
|
|
||
| namespace Semmle.Extraction.CSharp.Populators | ||
| { | ||
| internal class AstLineCounter : CSharpSyntaxVisitor<LineCounts> |
There was a problem hiding this comment.
Now Method no longer needs to be partial.
There was a problem hiding this comment.
Ahh, good point. Sorry...
tamasvajk
force-pushed
the
feature/refactor
branch
from
b41ebcc to
74db2cc
Compare
hvitved
previously approved these changes
Feb 15, 2021
tamasvajk
force-pushed
the
feature/refactor
branch
from
74db2cc to
2de7fbe
Compare
|
@hvitved I rebased this, and fixed the build issue after the rebase. Let's see if the tests pass, and if so, then it's ready to be merged. |
hvitved
approved these changes
Feb 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first in multiple steps to remove nullability warnings. Currently when the context is created for CIL extraction,
nullis passed as scope and compilation, which results in two nullability warnings. To overcome this, I think the best approach would be to have dedicated source and CIL extraction context classes. This PR only moves around functionalities. Most importantly, thestaticLocationfactories are moved to instance methods on theContext, which will later allow us to override them.Differences job