Skip to content

Changed Queue.peekFront() to return front.data not front.next.data #2091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Changed Queue.peekFront() to return front.data not front.next.data #2091

wants to merge 1 commit into from

Conversation

ra-res
Copy link

@ra-res ra-res commented Jan 25, 2021 •
edited
Loading

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

References

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Java files are placed inside an existing directory.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • All functions and variable names follow Java naming conventions.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

/Java/DataStructures/Queues/LinkedQueue
Implementation of peekFront() doesn't match it's documented description.
It is described as if it returns the first element without removing it, however, it returns the second element (front.next.data)

@ra-res ra-res changed the title Changed Queue.peek() to return front.data not front.next.data Changed Queue.peekFront() to return front.data not front.next.data Jan 25, 2021
mamadaliev
mamadaliev approved these changes May 5, 2021
View reviewed changes
Copy link

@mamadaliev mamadaliev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, +1 from me.

@ra-res ra-res requested a review from siriak as a code owner September 17, 2021 09:47
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Sep 26, 2021
@github-actions
Copy link

Please reopen this pull request once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to seek help from our Gitter or ping one of the reviewers. Thank you for your contributions!

@github-actions github-actions bot closed this Sep 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamadaliev mamadaliev mamadaliev approved these changes

@siriak siriak Awaiting requested review from siriak siriak is a code owner

Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ra-res @mamadaliev