Rust: ignore target in qltest
#19542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The target file created by `cargo check` was causing problems in language tests. We might want to also ignore `target` by default in the production indexing, but I'll leave that for further discussion.
There was a problem hiding this comment.
Pull Request Overview
This PR updates the qltest extractor to skip target directories when collecting test source files, preventing build artifacts from being included in language tests.
- Adds a filter to exclude paths starting with
target - Ensures errors during globbing still propagate correctly
Comments suppressed due to low confidence (1)
rust/extractor/src/qltest.rs:54
- Add a unit test for
set_sourcesthat includes sample paths both inside and outside atargetdirectory to verify the filtering logic works as intended.
fn set_sources(config: &mut Config) -> anyhow::Result<()> {
geoffw0
approved these changes
May 20, 2025
aibaars
reviewed
May 20, 2025
| @@ -54,6 +54,7 @@ path = "main.rs" | |||
| fn set_sources(config: &mut Config) -> anyhow::Result<()> { | |||
| let path_iterator = glob("**/*.rs").context("globbing test sources")?; | |||
| config.inputs = path_iterator | |||
| .filter(|f| f.is_err() || !f.as_ref().unwrap().starts_with("target")) | |||
There was a problem hiding this comment.
I guess your intention is to keep Err paths, right? So any errors are not silently ignored. If you just want to drop Err paths then it might be nicer to use f.is_ok_and() instead of the is_err check and unwrapping.
There was a problem hiding this comment.
yeah, I hesitated between the two, but in the end opted for not suppressing the errors for now
aibaars
approved these changes
May 20, 2025
|
Seems to have worked, everything is looking better this morning. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The target file created by
cargo checkwas causing problems in language tests.We might want to also ignore
targetby default in the production indexing, but I'll leave that for further discussion.