Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT make plot_digits_denoising deterministic by fixing random state #26004

Merged
merged 6 commits into from Mar 29, 2023
Merged

MAINT make plot_digits_denoising deterministic by fixing random state #26004

merged 6 commits into from Mar 29, 2023

Conversation

mdarii
Copy link
Contributor

@mdarii mdarii commented Mar 28, 2023

Reference Issues/PRs

related to #17568

What does this implement/fix? Explain your changes.

Added random state to the PCA and KernelPCA for fixing randomness.
It will avoid that the image is changing at each example generation.

glemaitre
glemaitre approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I look at the message and not changes are affecting the narrative. LGTM.
Thanks @mdarii I will merge it as is.

@glemaitre glemaitre merged commit 2fbded2 into scikit-learn:main Mar 29, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glemaitre glemaitre glemaitre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mdarii @glemaitre