FIX improve error message when computing NDCG with a single document #25672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adrinjalali @glemaitre If you'd give some feedback, it would be much appreciated! |
glemaitre
changed the title
glemaitre
reviewed
Feb 24, 2023
adrinjalali
approved these changes
Feb 27, 2023
There was a problem hiding this comment.
LGTM. The changes around L1689-1691 are not related to this PR, but I personally don't mind either way.
Please add a changelog entry in this file https://github.com/scikit-learn/scikit-learn/blob/main/doc/whats_new/v1.3.rst
Closed
NDCG is a metric to rank search request or such. A document is just the one input that you want to grade. |
glemaitre
reviewed
Mar 15, 2023
glemaitre
approved these changes
Mar 15, 2023
glemaitre
reviewed
Mar 24, 2023
|
Thanks all. Merging. LGTM |
1 similar comment
|
Thanks all. Merging. LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Reference Issues/PRs
Fixes #21335
closes #24482
What does this implement/fix? Explain your changes.
Check that the input array to
ndcg_score()has a length greater than 1 and throw aValueErrorwith a meaningful error message if not.Any other comments?
With the gracious help of @wcchu.