New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST use global_random_seed in sklearn/gaussian_process/tests/test_gpc.py #24600

Open

OmarManzoor wants to merge 1 commit into scikit-learn:main from OmarManzoor:global_random_seed_test_gpc

+10 −5

Contributor

OmarManzoor commented Oct 7, 2022

Reference Issues/PRs

Towards #22827

What does this implement/fix? Explain your changes.

Added global_random_seed in test_gpc.py
The two tests that were enhanced by this fixture are test_random_starts and test_custom_optimizer

Any other comments?

Since these tests are taking quite a while to run I am trying them out with the 0-9 seeds.
The test_custom_optimizer was failing for 1 out of the 10 seeds so I changed the training size.
The test_random_starts is taking about 1.23s even with only 10 seeds so should we just leave this method out?


          TST use global_random_seed in sklearn/gaussian_process/tests/test_gpc.py

d8fb9fe

github-actions bot added the module:gaussian_process label

cmarmo added the No Changelog Needed label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment