gh-134357: Remove unused imports in tests #134340
Merged
+26
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugovk
changed the title
hugovk
requested review from
ericsnowcurrently,
FFY00,
JelleZijlstra,
AlexWaygood,
gaogaotiantian,
vsajip,
gpshead,
picnixz,
tiran and
AA-Turner
as code owners
vstinner
approved these changes
May 20, 2025
| @@ -2728,7 +2727,6 @@ def iter_builtin_types(): | |||
| # Fall back to making a best-effort guess. | |||
| if hasattr(object, '__flags__'): | |||
| # Look for any type object with the Py_TPFLAGS_STATIC_BUILTIN flag set. | |||
| import datetime | |||
There was a problem hiding this comment.
This import has to stay. It deserves a # noqa: F401.
@encukou: Can you confirm?
AA-Turner
reviewed
May 20, 2025
AA-Turner
reviewed
May 22, 2025
Comment on lines
+9
to
+10
| ChannelError, ChannelNotFoundError, ChannelClosedError, # noqa: F401 | ||
| ChannelEmptyError, ChannelNotEmptyError, # noqa: F401 |
There was a problem hiding this comment.
In this specific case maybe better to add a per-file ignore?
There was a problem hiding this comment.
Or would you prefer the two unused imports on the same line? That way we still check the rest of the file.
Suggested change
| ChannelError, ChannelNotFoundError, ChannelClosedError, # noqa: F401 | |
| ChannelEmptyError, ChannelNotEmptyError, # noqa: F401 | |
| from _interpchannels import ( | |
| ChannelError, ChannelNotFoundError, ChannelEmptyError, | |
| ChannelClosedError, ChannelNotEmptyError, # noqa: F401 | |
| ) |
There was a problem hiding this comment.
I'm fine with the current PR: two lines with # noqa: F401.
picnixz
approved these changes
May 23, 2025
|
I think a few new ones crept in |
JelleZijlstra
approved these changes
May 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like #120417 and #131152, remove unused imports in tests.
Also add lint rule (F401) to the Ruff
Lib/test/config.