Skip to content

gh-108172: do not override OS preferred browser if it is a super-string of a known browser #113011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 31, 2024
Merged

gh-108172: do not override OS preferred browser if it is a super-string of a known browser #113011

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2b7821b
Issue #108172: substring search makes no sense
guss77 Dec 12, 2023
837fcdd
📜🤖 Added by blurb_it and fixed up
blurb-it[bot] Dec 12, 2023
b179560
Merge branch 'main' into patch-1
guss77 May 4, 2024
59e70c0
Merge branch 'main' into patch-1
AlexWaygood Aug 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/webbrowser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ def register(name, klass, instance=None, *, preferred=False):
# Preferred browsers go to the front of the list.
# Need to match to the default browser returned by xdg-settings, which
# may be of the form e.g. "firefox.desktop".
if preferred or (_os_preferred_browser and name in _os_preferred_browser):
if preferred or (_os_preferred_browser and f'{name}.desktop' == _os_preferred_browser):
_tryorder.insert(0, name)
else:
_tryorder.append(name)
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2023-12-12-15-19-58.gh-issue-108172.KyDPuG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
``webbrowser`` honors OS preferred browser on Linux when its desktop entry name contains the text of a known browser name.
Loading