Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C-analyzer tool cannot parse #line directives #102737

Open
AlexWaygood opened this issue Mar 15, 2023 · 1 comment
Open

C-analyzer tool cannot parse #line directives #102737

AlexWaygood opened this issue Mar 15, 2023 · 1 comment
Assignees
Labels
type-bug An unexpected behavior, bug, or error

Comments

@AlexWaygood
Copy link
Member

AlexWaygood commented Mar 15, 2023

Bug report

#line directives were added to generated_cases.c.h in 70185de, but the C-analyzer tool cannot handle these directives. This caused the CI check to start failing on all PRs, e.g.:

The short term fix is to exclude ceval.c from the C-analyzer tool:

But ideally we'd remove ceval.c from the excluded files and teach the C-analyzer tool to handle #line directives.

Linked PRs

@rhettinger
Copy link
Contributor

Ideally, this tool should have an overall try/except so that if a failure is caused by the tool being broken then it won't block all the pending PRs. The tool failing is a different and less interesting case than when it finds the issue it was designed to detect.

Also, if a tool has a risk of false positives, it should be attached to one of the buildbots that isn't one of the few required to make a commit. It should simply report failures rather than bringing all development to a halt.

ericsnowcurrently added a commit that referenced this issue Mar 16, 2023
The tool now allows user-added #LINE preprocessor directives.

#102737
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

No branches or pull requests

3 participants