Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-93491: Add support tier detection to configure (GH-93492) #93492

Merged
merged 9 commits into from Jun 10, 2022

Conversation

tiran
Copy link
Member

@tiran tiran commented Jun 4, 2022

No description provided.

Copy link
Member

@AA-Turner AA-Turner left a comment

Small wording suggestions (I don't know enough about configure etc to review the change itself, sorry).

A

configure.ac Outdated Show resolved Hide resolved
configure.ac Outdated Show resolved Hide resolved
pyconfig.h.in Outdated Show resolved Hide resolved
Copy link
Member Author

@tiran tiran left a comment

Thanks for your feedback!

zooba
zooba approved these changes Jun 7, 2022
Copy link
Member

@zooba zooba left a comment

Approved PC/pyconfig.h with changes.

PC/pyconfig.h Outdated Show resolved Hide resolved
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Nice. I left some comments regarding message levels.

configure.ac Outdated Show resolved Hide resolved
configure.ac Outdated Show resolved Hide resolved
tiran and others added 7 commits Jun 10, 2022
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Steve Dower <steve.dower@microsoft.com>
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
configure.ac Outdated Show resolved Hide resolved
tiran and others added 2 commits Jun 10, 2022
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
@erlend-aasland erlend-aasland linked an issue Jun 10, 2022 that may be closed by this pull request
@tiran tiran changed the title gh-93491: Add support tier detection to configure gh-93491: Add support tier detection to configure (GH-93492) Jun 10, 2022
@tiran tiran merged commit 3124d9a into python:main Jun 10, 2022
13 checks passed
@tiran tiran deleted the support-tier branch Jun 10, 2022
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jun 10, 2022

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒🤖

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jun 10, 2022

GH-93683 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 10, 2022
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Steve Dower <steve.dower@microsoft.com>
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
(cherry picked from commit 3124d9a)

Co-authored-by: Christian Heimes <christian@python.org>
miss-islington added a commit that referenced this issue Jun 10, 2022
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Steve Dower <steve.dower@microsoft.com>
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
(cherry picked from commit 3124d9a)

Co-authored-by: Christian Heimes <christian@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants