gh-134887: Add references to locale module for locale-aware number formatting references in string module docs
#134888
+13
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
stefmolin
changed the title
locale module for locale-aware number formatting references in string module docslocale module for locale-aware number formatting references in string module docs
stefmolin
changed the title
locale module for locale-aware number formatting references in string module docslocale module for locale-aware number formatting references in string module docs
DangNhutNguyen
approved these changes
May 29, 2025
Doc/library/string.rst
Outdated
| For a locale aware separator, use the ``'n'`` presentation type instead. | ||
| For a locale-aware separator, use the ``'n'`` presentation type instead. Note | ||
| that the locale setting for numeric values must first be set using the | ||
| :mod:`locale` module, *e.g.,* ``locale.setlocale(locale.LC_NUMERIC, 'en_US')``. |
There was a problem hiding this comment.
There was a problem hiding this comment.
There are two other occurrences of "e.g." in this document that pre-date my changes. Would you like me to update those as well?
ericvsmith
reviewed
May 29, 2025
| For a locale-aware separator, use the ``'n'`` presentation type instead. | ||
| Note that the locale setting for numeric values must first be set using | ||
| the :mod:`locale` module, for example, | ||
| ``locale.setlocale(locale.LC_NUMERIC, 'en_US')``. |
There was a problem hiding this comment.
Why refer to this here? At most it just belongs in the n section.
| | | digit group separators. | | ||
| | | digit group separators. Note that the default locale is | | ||
| | | not the system locale, and therefore, you must set, at a | | ||
| | | minimum, the ``LC_NUMERIC`` category (see the | |
There was a problem hiding this comment.
This isn't true, is it? I'm referring to the wording "must set": shouldn't it be "can set".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add references to
localemodule for locale-aware number formatting references instringmodule docs to avoid users thinking that the locale doesn't have a thousands separator for example.nin the format-specifier should reference locale-setting #134887