Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT Clean-up remaining SGDClassifier(loss="log") #25938

Merged
merged 2 commits into from Mar 22, 2023
Merged

MAINT Clean-up remaining SGDClassifier(loss="log") #25938

merged 2 commits into from Mar 22, 2023
+9 −5

Conversation

jeremiedbb
Copy link
Member

Follow-up of #25865

There were a few leftovers. Searching for "log" shows a lot of false positive but at least I think I got them all now.

@jeremiedbb jeremiedbb added No Changelog Needed Quick Review For PRs that are quick to review labels Mar 22, 2023
ogrisel
ogrisel approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the follow-up.

sklearn/tests/test_multioutput.py Show resolved Hide resolved
thomasjpfan
thomasjpfan approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan merged commit e75d8a6 into scikit-learn:main Mar 22, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
module:linear_model No Changelog Needed Quick Review For PRs that are quick to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jeremiedbb @ogrisel @thomasjpfan