Skip to content
Sign up
This repository

/ruby

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

* lib/net/http.rb: fixed https doc error #96

Closed
wants to merge 1 commit into from
+1 −1 

Labels

Milestone

No milestone

Assignee

No one assigned

2 participants

florian mhun Ayumu AIZAWA
florian mhun
floomoon commented

Hello,

I found an error in net/http documentation :

Net::HTTP.start(uri.host, uri.port,
  :use_ssl => uri.scheme == 'https').start do |http|
  request = Net::HTTP::Get.new uri.request_uri

  response = http.request request # Net::HTTPResponse object
end

The first line call start() method 2 times here.

Ayumu AIZAWA
Collaborator
ayumin commented

Merged by r3781. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Feb 19, 2012
  1. florian mhun

    * lib/net/http.rb: fixed https doc error

    floomoon authored
    c6b296e
This page is out of date. Refresh to see the latest.
Unified Split
Showing with 1 addition and 1 deletion.
  1. +1 −1  lib/net/http.rb
2  lib/net/http.rb
View
@@ -256,7 +256,7 @@ class HTTPHeaderSyntaxError < StandardError; end
# uri = URI('https://secure.example.com/some_path?query=string')
#
# Net::HTTP.start(uri.host, uri.port,
- # :use_ssl => uri.scheme == 'https').start do |http|
+ # :use_ssl => uri.scheme == 'https') do |http|
# request = Net::HTTP::Get.new uri.request_uri
#
# response = http.request request # Net::HTTPResponse object
Something went wrong with that request. Please try again.