Fix bug that causes YAML serialization problem for Exception. …
The implementation of YAML.object_maker allocates an object and instance_variable_set the instance variables passed as the second argument, while Exception doesn't seem to use such instance variable to return the exception message (Exception#message). This bug can be reproduced by typing YAML::load(YAML::dump(Exception.new('test_message'))) in IRB.

The implementation of YAML.object_maker allocates an object and instance_variable_set the instance variables passed as the second argument, while Exception doesn't seem to use such instance variable to return the exception message (Exception#message). This bug can be reproduced by typing YAML::load(YAML::dump(Exception.new('test_message'))) in IRB.
Fix bug that causes YAML serialization problem for Exception. …
ruby · jingweno · jingweno · jingweno · jingweno · shyouhei
Unified Split

Showing with 5 additions and 2 deletions.

+4 −1  ext/syck/lib/syck/rubytypes.rb

+1 −1  test/syck/test_exception.rb
@@ -122,7 +122,10 @@ def to_yaml( opts = {} )
 class Exception
     yaml_as "tag:ruby.yaml.org,2002:exception"
     def Exception.yaml_new( klass, tag, val )
-        o = YAML.object_maker( klass, { 'mesg' => val.delete( 'message' ) } )
+        o = klass.allocate
+        Exception.instance_method(:initialize).
+                  bind(o).
+                  call( val.delete( 'message' )  )
         val.each_pair do |k,v|
             o.instance_variable_set("@#{k}", v)
         end
@@ -13,7 +13,7 @@ def initialize *args
     end
 
     def setup
-      @wups = Wups.new
+      @wups = Wups.new('test_message')
     end
 
     def test_to_yaml