Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.0] Remove timestamp from create_failed_jobs_table file #5082

Merged
merged 1 commit into from Aug 21, 2019
Merged

[6.0] Remove timestamp from create_failed_jobs_table file #5082

merged 1 commit into from Aug 21, 2019

Conversation

arubacao
Copy link
Contributor

Remove timestamp from create_failed_jobs_table file.
From:
2019_08_19_175727_create_failed_jobs_table.php
To:
2019_08_19_000000_create_failed_jobs_table.php

@deleugpn
Copy link

Why?

@driesvints
Copy link
Member

There's no reason to do this imo.

@driesvints driesvints closed this Aug 20, 2019
@arubacao
Copy link
Contributor Author

It makes it more consistent with existing migrations in this repo and looks cleaner.

@fitztrev
Copy link

@driesvints @deleugpn that's how the other 2 migrations were named in f4a2282

@driesvints
Copy link
Member

Okay I'll reopen this to see what Taylor says.

@driesvints driesvints reopened this Aug 20, 2019
@GrahamCampbell GrahamCampbell changed the title Remove timestamp from create_failed_jobs_table file [6.0] Remove timestamp from create_failed_jobs_table file Aug 21, 2019
@taylorotwell taylorotwell merged commit b67acda into laravel:develop Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@arubacao @deleugpn @driesvints @fitztrev @taylorotwell