Remove fixPrototypeChain agency migration #14658
Merged
+5
∄1�751
Conversation
This was fixing a very rare user configuration in the collection setup and was introduced in 3.2. This change will make it impossible to upgrade from <= 3.1 directly to 3.9, provided somebody has a chain of `distributeShardsLike` settings, which is OK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This agency migration code was introduced with 3.2.1, as far as I see.
It handled the case that somebody might have three collections A, B and
C, with B having
distributeShardsLikeset to"A", and C havingdistributeShardsLikeset to"B", by migrating this to set C alsoto have
distributeShardsLikeset to"A".This migration was broken by a recent fix in
devel(not in 3.8),therefore no backports are necessary and no customers are in danger.
Note that this makes it impossible to upgrade directly from a version
< 3.2 to a version >= 3.9, if one has such a
distributeShardsLikechain as described above.
Scope & Purpose
(Please describe the changes in this PR for reviewers - mandatory)
Backports:
Related Information
(Please reference tickets / specification / other PRs etc)
https://arangodb.atlassian.net/browse/BTS-546
Testing & Verification
(Please pick either of the following options)
test automation.