Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-44976: Lazy creation of sqlite3 result rows #27884

Merged
merged 1 commit into from Aug 25, 2021
Merged

bpo-44976: Lazy creation of sqlite3 result rows #27884

merged 1 commit into from Aug 25, 2021

Conversation

Reviewers

@pablogsal pablogsal

@berkerpeksag berkerpeksag

@serhiy-storchaka serhiy-storchaka

Assignees
No one assigned
Labels
CLA signed skip news
Projects
None yet
Milestone
No milestone
4 participants
@erlend-aasland @bedevere-bot @pablogsal @the-knights-who-say-ni
@erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Aug 22, 2021 •
edited by bedevere-bot

  • remove 'next_row' member from Cursor object
  • remove _pysqlite_fetch_one_row() call from query execute loop
  • as a result of the two above, pysqlite_cursor_iternext() is vastly simplified

https://bugs.python.org/issue44976
@erlend-aasland
Only build result rows when needed
ce0d55f 
- remove 'next_row' member in Cursor object
- remove fetch-one-row call from query execute loop
- rewrite cursor iternext method to comply with the new behaviour
@erlend-aasland
Copy link
Contributor Author

@erlend-aasland erlend-aasland commented Aug 22, 2021

Internal change; no user-visible or backwards incompatible changes; skipping news.

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Aug 22, 2021

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit ce0d55f 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

@erlend-aasland
Copy link
Contributor Author

@erlend-aasland erlend-aasland commented Aug 22, 2021

The AMD64 Arch Linux Asan Debug PR buildbot failure seems to be unrelated. I see that it's been failing a lot recently.

@pablogsal pablogsal merged commit 3df0fc8 into python:main Aug 25, 2021
73 of 74 checks passed
@erlend-aasland erlend-aasland deleted the sqlite-fetch-when-needed branch Aug 25, 2021
@erlend-aasland
Copy link
Contributor Author

@erlend-aasland erlend-aasland commented Aug 25, 2021

Thanks, Pablo!

erlend-aasland added a commit to erlend-aasland/cpython that referenced this issue Aug 25, 2021
@erlend-aasland
Sync with 'main' bco. pythonGH-27884
0633095
@erlend-aasland erlend-aasland mentioned this pull request Aug 26, 2021
Open
@erlend-aasland erlend-aasland mentioned this pull request Sep 14, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment