gh-95027: Fix regrtest stdout encoding on Windows #98492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I failed to write a test reproducing the bug in test_regrtest, since test_regrtest runs the test suite with stdout being a pipe, which works around the bug :-( I tried to add this test: def test_nonascii(self):
character = chr(0xe9)
line = f"nonascii: {character}"
encoding = locale.getencoding()
try:
line.encode(encoding)
except EncodingError:
self.skipTest(f"fail to encode character U+00E9 "
f"to locale encoding {encoding}")
code = textwrap.dedent(f"""
import unittest
class Tests(unittest.TestCase):
def test_nonascii(self):
line = {line!a}
print(line)
""")
testname = self.create_test(code=code)
# sequential execution: may use the terminal
output = self.run_tests(testname)
self.check_executed_tests(output, [testname])
self.assertIn(line, output)
# parallel execution: stdout is a temporary file
output = self.run_tests("-j1", testname)
self.check_executed_tests(output, [testname])
self.assertIn(line, output) |
On Windows, when the Python test suite is run with the -jN option, the ANSI code page is now used as the encoding for the stdout temporary file, rather than using UTF-8 which can lead to decoding errors.
|
Thanks @vstinner for the PR |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 21, 2022
On Windows, when the Python test suite is run with the -jN option, the ANSI code page is now used as the encoding for the stdout temporary file, rather than using UTF-8 which can lead to decoding errors. (cherry picked from commit ec1f6f5) Co-authored-by: Victor Stinner <vstinner@python.org>
|
I would prefer a formal review, but I merged my PR just to unblock the 3.11.0 final release (scheduled next Monday). Maybe if something can be enhanced, it can be done later. IMO this fix is better than the current situation. In short, it just restores the old behavior: encodings used before 199ba23 |
|
Thanks @vstinner for the PR |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 21, 2022
On Windows, when the Python test suite is run with the -jN option, the ANSI code page is now used as the encoding for the stdout temporary file, rather than using UTF-8 which can lead to decoding errors. (cherry picked from commit ec1f6f5) Co-authored-by: Victor Stinner <vstinner@python.org>
|
3.11 backport: #98521 (review) |
miss-islington
added a commit
that referenced
this pull request
Oct 21, 2022
On Windows, when the Python test suite is run with the -jN option, the ANSI code page is now used as the encoding for the stdout temporary file, rather than using UTF-8 which can lead to decoding errors. (cherry picked from commit ec1f6f5) Co-authored-by: Victor Stinner <vstinner@python.org>
pablogsal
pushed a commit
that referenced
this pull request
Oct 24, 2022
On Windows, when the Python test suite is run with the -jN option, the ANSI code page is now used as the encoding for the stdout temporary file, rather than using UTF-8 which can lead to decoding errors. (cherry picked from commit ec1f6f5) Co-authored-by: Victor Stinner <vstinner@python.org>
pablogsal
pushed a commit
that referenced
this pull request
Oct 24, 2022
On Windows, when the Python test suite is run with the -jN option, the ANSI code page is now used as the encoding for the stdout temporary file, rather than using UTF-8 which can lead to decoding errors. (cherry picked from commit ec1f6f5) Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
On Windows, when the Python test suite is run with the -jN option, the ANSI code page is now used as the encoding for the stdout temporary file, rather than using UTF-8 which can lead to decoding errors.