gh-94808: Cover PyObject_PyBytes
case with custom __bytes__
method
#96610
+16
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
There were two options:
_testcapimodule.c
function to testPyObject_PyBytes
directly. But, there's alreadypyobject_bytes_from_null
which only coversNULL
case. So, it is somewhat coveredPyObject_Bytes
, likeint_from_bytes_impl
. In this case we not only test C-API itself, but also do something useful for the end implementation (in this caseint.from_bytes
)So, I went with
2.
Probably it is still possible to add a new
_testcapimodule.c
function in the next PR.