New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-101863: Fix wrong comments in EUC-KR codec #102417
gh-101863: Fix wrong comments in EUC-KR codec #102417
Conversation
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add your name to the following file.
Lines 324 to 325 in 8de59c1
Kit Yan Choi | |
Sayan Chowdhury |
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
This PR fix the wrong comments in the code related to #101863.
The encoding method using "Hangul Filler" is defined in subclause 4.3 of KS X 1001, whereas Annex 3 defines an alternative 2-byte Johab code.