[AssetMapper] Avoid loading potentially ALL assets in dev server #50394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
force-pushed
the
asset-mapper-dev-public-path-cache
branch
from
4691fc9 to
2f76e18
Compare
nicolas-grekas
added
the
❄️ Feature Freeze
nicolas-grekas
removed
the
❄️ Feature Freeze
weaverryan
force-pushed
the
asset-mapper-dev-public-path-cache
branch
from
2f76e18 to
a89b732
Compare
|
Just made |
|
Tests fail :) |
weaverryan
force-pushed
the
asset-mapper-dev-public-path-cache
branch
from
f973828 to
a340568
Compare
Only because my tests were so good 😛. It's better now - sorry about that. One failure is unrelated. |
nicolas-grekas
force-pushed
the
asset-mapper-dev-public-path-cache
branch
from
df81762 to
bb97591
Compare
|
Thank you @weaverryan. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
One other rough edge found when using on a real project. The dev server needs to quickly go from "public path" -> "logical path", so it can then look up the
MappedAsset. Previously, for every served asset, it would loop over ALL assets until it found a match. We have aCachedMappedAssetFactory, which makes this happen quickly, but it still loads many assets into memory, including their contents. I was seeing a 13mb jump in the memory on those requests in a modest-sized app. If someone was serving a lot of images, it could get huge. No reason to do that work multiple times.Btw, none of this happens on production - caching is here just for dev experience.
Thanks!