[FrameworkBundle] Allow BrowserKit relative URL redirect assert #44629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienfalque
force-pushed
the
relative-redirect-assert
branch
5 times, most recently
from
c605745 to
d864b80
Compare
julienfalque
force-pushed
the
relative-redirect-assert
branch
from
d864b80 to
a720f67
Compare
fabpot
reviewed
Dec 11, 2022
| @@ -47,7 +47,13 @@ public static function assertResponseRedirects(string $expectedLocation = null, | |||
| { | |||
| $constraint = new ResponseConstraint\ResponseIsRedirected(); | |||
| if ($expectedLocation) { | |||
| $constraint = LogicalAnd::fromConstraints($constraint, new ResponseConstraint\ResponseHeaderSame('Location', $expectedLocation)); | |||
| if (class_exists(ResponseConstraint\ResponseHeaderLocationSame::class)) { | |||
| $locationConstraint = new ResponseConstraint\ResponseHeaderLocationSame(self::getRequest(), $expectedLocation); | |||
There was a problem hiding this comment.
Would it make sense to have a more generic ResponseHeaderUrlSame for all headers consisting of a URL?
There was a problem hiding this comment.
I'm not sure. The behavior for Location depends on the URL of the request, would this behavior make sense for any kind of URL?
julienfalque
force-pushed
the
relative-redirect-assert
branch
3 times, most recently
from
59deba5 to
6cdb5d4
Compare
fabpot
approved these changes
Oct 1, 2023
|
Thank you @julienfalque. |
fabpot
force-pushed
the
relative-redirect-assert
branch
from
6cdb5d4 to
fb4e9ae
Compare
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In tests, when asserting a redirect happens, it can be convenient to skip the host part in the expected location, assuming it is the same as the one from the request's URL.