Skip to content

[Workflow] Remove GuardEvent::getContext() method without replacement #51549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2023
Merged

[Workflow] Remove GuardEvent::getContext() method without replacement #51549

merged 1 commit into from
Sep 5, 2023

Conversation

alexandre-daubois
Copy link
Member

Q A
Branch? 7.0
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Follow-up of #51484

@carsonbot carsonbot added this to the 7.0 milestone Sep 4, 2023
@stof
Copy link
Member

stof commented Sep 4, 2023

The upgrade-7.0 file must also be updated

@alexandre-daubois
Copy link
Member Author

alexandre-daubois commented Sep 4, 2023 •
edited
Loading

Actually, it has been already done last week:

symfony/UPGRADE-7.0.md

Lines 489 to 493 in d1774f4

Workflow
--------
* Require explicit argument when calling `Definition::setInitialPlaces()`
* `GuardEvent::getContext()` method has been removed. Method was not supposed to be called within guard event listeners as it always returned an empty array anyway.

@stof
Copy link
Member

stof commented Sep 4, 2023

ah OK. so this is something that has been forgotten in #51493 actually.

@fabpot
Copy link
Member

fabpot commented Sep 5, 2023

Thank you @alexandre-daubois.

@fabpot fabpot mentioned this pull request Sep 5, 2023
Closed
@fabpot fabpot merged commit 75119b0 into symfony:7.0 Sep 5, 2023
@fabpot fabpot mentioned this pull request Oct 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@stof stof stof approved these changes

@lyrixx lyrixx Awaiting requested review from lyrixx lyrixx is a code owner

Assignees
No one assigned
Labels
Status: Reviewed Workflow
Projects
None yet
Milestone
7.0
Development

Successfully merging this pull request may close these issues.
4 participants
@alexandre-daubois @stof @fabpot @carsonbot