Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-38400 Don't check for NULL linked list pointers in _PyObject_IsFreed #16630
Conversation
Some objects like Py_None are not initialized with conventional means that prepare the circular linked list pointers, leaving them unlinked from the rest of the objects. For those objects, NULL pointers does not mean that they are freed, so we need to skip the check in those cases.
pablogsal
changed the title
|
LGTM. |
jacobneiltaylor
added a commit
to jacobneiltaylor/cpython
that referenced
this pull request
Dec 5, 2019
…eed (pythonGH-16630) Some objects like Py_None are not initialized with conventional means that prepare the circular linked list pointers, leaving them unlinked from the rest of the objects. For those objects, NULL pointers does not mean that they are freed, so we need to skip the check in those cases.
This comment has been minimized.
This comment has been minimized.
miss-islington
commented
Jan 19, 2020
|
Thanks @pablogsal for the PR |
This comment has been minimized.
This comment has been minimized.
miss-islington
commented
Jan 19, 2020
|
Thanks @pablogsal for the PR |
miss-islington
added a commit
to miss-islington/cpython
that referenced
this pull request
Jan 19, 2020
…eed (pythonGH-16630) Some objects like Py_None are not initialized with conventional means that prepare the circular linked list pointers, leaving them unlinked from the rest of the objects. For those objects, NULL pointers does not mean that they are freed, so we need to skip the check in those cases. (cherry picked from commit 36e33c3) Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Jan 19, 2020
|
GH-18072 is a backport of this pull request to the 3.8 branch. |
miss-islington
added a commit
to miss-islington/cpython
that referenced
this pull request
Jan 19, 2020
…eed (pythonGH-16630) Some objects like Py_None are not initialized with conventional means that prepare the circular linked list pointers, leaving them unlinked from the rest of the objects. For those objects, NULL pointers does not mean that they are freed, so we need to skip the check in those cases. (cherry picked from commit 36e33c3) Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Jan 19, 2020
|
GH-18073 is a backport of this pull request to the 3.7 branch. |
miss-islington
added a commit
that referenced
this pull request
Jan 19, 2020
…eed (GH-16630) Some objects like Py_None are not initialized with conventional means that prepare the circular linked list pointers, leaving them unlinked from the rest of the objects. For those objects, NULL pointers does not mean that they are freed, so we need to skip the check in those cases. (cherry picked from commit 36e33c3) Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
miss-islington
added a commit
that referenced
this pull request
Jan 19, 2020
…eed (GH-16630) Some objects like Py_None are not initialized with conventional means that prepare the circular linked list pointers, leaving them unlinked from the rest of the objects. For those objects, NULL pointers does not mean that they are freed, so we need to skip the check in those cases. (cherry picked from commit 36e33c3) Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pablogsal commentedOct 7, 2019
•
edited by miss-islington
https://bugs.python.org/issue38400
Automerge-Triggered-By: @pablogsal