Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-45512: Raise exception if sqlite3.Connection.__init__ is called with bad isolation level #29561

Merged
merged 4 commits into from Nov 15, 2021
Merged

bpo-45512: Raise exception if sqlite3.Connection.__init__ is called with bad isolation level #29561

merged 4 commits into from Nov 15, 2021

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Nov 15, 2021 •
edited by bedevere-bot

@erlend-aasland erlend-aasland requested a review from corona10 Nov 15, 2021
@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Nov 15, 2021

cc. @corona10: Make sure we always raise an exception when __init__ fails.

@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Nov 15, 2021

Adding skip news, since this regression is not present in any official release. It is just an amendment of GH-29053.

@corona10
Update Lib/test/test_sqlite3/test_dbapi.py
620015f 
Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
@erlend-aasland erlend-aasland requested a review from corona10 Nov 15, 2021
@erlend-aasland erlend-aasland changed the title bpo-45512: Raise if sqlite3.Connection.__init__ is called with bad isolation level bpo-45512: Raise exception if sqlite3.Connection.__init__ is called with bad isolation level Nov 15, 2021
@corona10 corona10 merged commit 822c3dc into python:main Nov 15, 2021
11 checks passed
@bedevere-bot
Copy link

bedevere-bot commented Nov 15, 2021

@corona10: Please replace # with GH- in the commit message next time. Thanks!

@erlend-aasland erlend-aasland deleted the sqlite-fix-bad-init branch Nov 15, 2021
@bedevere-bot
Copy link

bedevere-bot commented Nov 15, 2021

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM64 macOS 3.x has failed when building commit 822c3dc.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/725/builds/355) and take a look at the build logs.
  4. Check if the failure is related to this commit (822c3dc) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/725/builds/355

Summary of the results of the build (if available):

== Tests result: ENV CHANGED ==

410 tests OK.

10 slowest tests:

  • test_concurrent_futures: 3 min 31 sec
  • test_multiprocessing_spawn: 2 min 32 sec
  • test_multiprocessing_forkserver: 1 min 51 sec
  • test_unparse: 1 min 28 sec
  • test_asyncio: 1 min 19 sec
  • test_tokenize: 1 min 15 sec
  • test_logging: 1 min
  • test_lib2to3: 56.2 sec
  • test_capi: 50.7 sec
  • test_signal: 46.2 sec

1 test altered the execution environment:
test_ftplib

16 tests skipped:
test_devpoll test_epoll test_gdb test_ioctl test_msilib
test_multiprocessing_fork test_ossaudiodev test_spwd
test_startfile test_tix test_tk test_ttk_guionly test_winconsoleio
test_winreg test_winsound test_zipfile64

Total duration: 8 min 42 sec

Click to see traceback logs 
Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
    ^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: '/psm_8bee32fe'


Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
    ^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: '/psm_07a4aad1'


Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/asyncore.py", line 90, in read
    obj.handle_read_event()
    ^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_ftplib.py", line 384, in handle_read_event
    self._do_ssl_handshake()
    ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_ftplib.py", line 345, in _do_ssl_handshake
    self.socket.do_handshake()
    ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/ssl.py", line 1346, in do_handshake
    self._sslobj.do_handshake()
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^
ssl.SSLZeroReturnError: TLS/SSL connection has been closed (EOF) (_ssl.c:998)


Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/threading.py", line 1031, in _bootstrap_inner
    self.run()
    ^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_ftplib.py", line 298, in run
    asyncore.loop(timeout=0.1, count=1)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/asyncore.py", line 214, in loop
    poll_fun(timeout, map)
    ^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/asyncore.py", line 157, in poll
    read(obj)
    ^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/asyncore.py", line 94, in read
    obj.handle_error()
    ^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_ftplib.py", line 421, in handle_error
    raise Exception
    ^^^^^^^^^^^^^^^
Exception
k

remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
@corona10 @remykarem
bpo-45512: Raise exception if sqlite3.Connection.__init__ is called w…
acb5f77 
…ith bad isolation level (python#29561)

* bpo-45512: Raise sqlite3.Connection.__init__ is called with bad isolation level

* Also explicitly test allowed isolation levels

* Use subTest for better error messages if something goes wrong

* Update Lib/test/test_sqlite3/test_dbapi.py

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
@erlend-aasland erlend-aasland mentioned this pull request May 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berkerpeksag berkerpeksag

@corona10 corona10

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@erlend-aasland @bedevere-bot @corona10 @the-knights-who-say-ni